Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch from cluster-autoscaler to karpenter #349

Merged
merged 6 commits into from
Jan 8, 2024
Merged

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented Dec 25, 2023

PR Description

  • Added karpenter resources into layer2-k8s
  • Enabled auto-assign public IPv4 by default for public networks. It can be disabled when this issue is resolved
  • Removed a cluster-autoscaler
  • Removed a node-termination-handler. Karpenter manages termination of spot instances by itself
  • Added a default nodepool (ASG) with spot instances (arm64) to run there coredns and karpenter
  • Deleted all nodepools, including Bottlerocket. We haven't used it yet.
  • Added required outputs in the layer1-aws
  • Changed nodeselectors for all workloads to use well-known Karpenter labels
  • Added karpenter nodepools: default and ci
  • Added karpenter ec2nodeclasses: public, private

Fixes #245

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov marked this pull request as draft December 25, 2023 11:32
@mglotov mglotov changed the title draft version feat: switch from cluster-autoscaler to karpenter Jan 8, 2024
@mglotov mglotov requested a review from a team January 8, 2024 03:49
@mglotov mglotov marked this pull request as ready for review January 8, 2024 03:49
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@halfb00t halfb00t self-requested a review January 8, 2024 09:42
@mglotov mglotov merged commit 5d4c293 into main Jan 8, 2024
10 checks passed
@mglotov mglotov deleted the karpenter-module branch January 8, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add possibility to use Karpenter
3 participants