Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set custom block types #57

Merged
merged 3 commits into from
Feb 19, 2019
Merged

Set custom block types #57

merged 3 commits into from
Feb 19, 2019

Conversation

raffij
Copy link
Contributor

@raffij raffij commented Feb 19, 2019

Improves performance for blocks which are not custom defined.

We no longer rely on NameError each time we load a block and only use this approach if the block is known to be custom defined.

@raffij raffij requested a review from ilyatulvio February 19, 2019 09:28
ilyatulvio
ilyatulvio approved these changes Feb 19, 2019
View reviewed changes
Copy link

@ilyatulvio ilyatulvio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raffij raffij merged commit 931b955 into master Feb 19, 2019
@raffij raffij deleted the set-custom-block-types branch February 19, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyatulvio ilyatulvio ilyatulvio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raffij @ilyatulvio