Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add -V and --version e2e test #40

Merged
merged 5 commits into from
Oct 16, 2019
Merged

feat: add -V and --version e2e test #40

merged 5 commits into from
Oct 16, 2019

Conversation

bdcorps
Copy link
Contributor

@bdcorps bdcorps commented Oct 10, 2019 •
edited
Loading

Description

Add e2e test for -v and --version flags.

Fixes #28

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@welcome
Copy link

welcome bot commented Oct 10, 2019

Thanks for opening this pull request! Please check out our contributing guidelines.

@bdcorps bdcorps closed this Oct 10, 2019
@bdcorps bdcorps reopened this Oct 10, 2019
jamesgeorge007
jamesgeorge007 requested changes Oct 14, 2019
View reviewed changes
test/index.js Outdated Show resolved Hide resolved
test/index.js Outdated Show resolved Hide resolved
@jamesgeorge007 jamesgeorge007 added enhancement New feature or request Hacktoberfest labels Oct 14, 2019
@jamesgeorge007 jamesgeorge007 added this to the v1.2.0 milestone Oct 14, 2019
jamesgeorge007
jamesgeorge007 requested changes Oct 15, 2019
View reviewed changes
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the linter issues with npm run lint:fix

jamesgeorge007
jamesgeorge007 approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jamesgeorge007 jamesgeorge007 merged commit 6a250a5 into madlabsinc:next Oct 16, 2019
@welcome
Copy link

welcome bot commented Oct 16, 2019

congrats
Congrats on your very first contribution 👏 Looking forward to having more from your side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

Assignees

@bdcorps bdcorps

Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Write e2e tests
2 participants
@bdcorps @jamesgeorge007