Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use load-ip-set #85

Closed
feross opened this issue Sep 13, 2014 · 3 comments
Closed

use load-ip-set #85

feross opened this issue Sep 13, 2014 · 3 comments

Comments

@feross
Copy link
Collaborator

feross commented Sep 13, 2014

Just wanted to let you know about load-ip-set which offers a superset of the current blocklist functionality.

Let's keep unifying torrent-stream and webtorrent code!

@mafintosh
Copy link
Owner

awesome! i'm a bit strapped for time these days but i'm all for this

@Coriou
Copy link

Coriou commented Nov 5, 2019

Hey.

I'm using a project based on torrent-stream (peerflix-server) and I'd like to implement blocklist support there. The way blocklist is currently implemented in torrent-stream requires the user to pass in a single range of IP on engine load on add IPs one by one to the set which is inconvenient in many cases.

Was thinking about implementing this at the application level, in my case Peerflix Server (as discussed there asapach/peerflix-server#173) but reading about this and the best way of doing it, I think it would make a lot of sense to just upgrade torrent-stream to use load-ip-set. This way, the blocklist system is much more effective and user friendly (just throw in a blocklist URL or file and you're good to go).

I can work on it, it's really a minor update, and it would benefit peerflix / peerflix-server too.

@feross
Copy link
Collaborator Author

feross commented Nov 18, 2020

I'm extremely strapped for time and can't implement this, so I'm closing this.

@feross feross closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants