Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility back files to repository #30

Open
vdubyna opened this issue Mar 25, 2013 · 4 comments
Open

Add the possibility back files to repository #30

vdubyna opened this issue Mar 25, 2013 · 4 comments

Comments

@vdubyna
Copy link

vdubyna commented Mar 25, 2013

Symlinks are not very useful in some cases as they do not work correct with __DIR__ and __FILE__ constants.

I suggest to add possibility to do reverse copy from the project to the vendor dir.

@Vinai
Copy link
Member

Vinai commented Mar 25, 2013

What would be the intended scenario?

  • Deploy using copy from vendor/ package dir
  • Develop within the Magento source tree
  • Copy from Magento source tree back to vendor/ package dir

Is that right? I can see the use for that. I think it would be best to create a command based on https://github.com/magento-hackathon/composer-command-integrator since this isn't really composer installer related.

@vdubyna
Copy link
Author

vdubyna commented Mar 25, 2013

Yes, that is right. It should be feature for developers. And the command line is what we need.
I've got some problems with https://github.com/magento-hackathon/composer-command-integrator
I'll add my proposals there too, but in a couple of days.

@Flyingmana
Copy link
Member

should be not so hard to achieve. nearly all of the code of MagentoHackathon\Composer\Magento\Command\DeployCommand can get reused.
I dont belive that simple switching the key/value of the mapping is enough, so we also need a extra deploystrategy similar to our copy.php which reverses the copy function in this line https://github.com/magento-hackathon/magento-composer-installer/blob/master/src/MagentoHackathon/Composer/Magento/Deploystrategy/Copy.php#L73

Anyone a suggestion how we can do this in a semantic correct way without copy the half code of both files?
I think about extracting the copy call into an own class method and simple extend from the copy.php so only one method needs to get overwritten. Same for the DeployCommand and the getDeployStrategy call.

Semantically not so good, but it would minimize the code which needs to get maintained.

@amenk
Copy link
Contributor

amenk commented Jun 11, 2013

On which modules does that cause problems? I basically like to have everything in vendor and now where else. I install using "composer.phar --prefer-source" so I have direct access to the upstream GIT repos and can make pull requests and so on.

AydinHassan pushed a commit to AydinHassan/magento-composer-installer that referenced this issue Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants