Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@magento run all tests

@magento run Static Tests, Functional Tests B2B

Hello @engcom-Hotel ,

No, Still the issue exists on the latest 2.4-develop, i verified in my local env

@engcom-Hotel Do i need to add MFTF ? or Jasmine test case ? and also i don't know see any build failure related to this PR, could you please let me know, what are the build failure regarding this PR ?

Hello @Mohamed-Asar,

I would suggest you add an MFTF to verify the code changes.

for build failures lets try to re-run the tests, they might be flaky.

Thanks

@magento run all tests

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Static Tests, Unit Tests

@magento run Functional Tests EE, Static Tests

@magento run all tests

Hi @Mohamed-Asar,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• Go to grouped product PDP
• Add invalid qty in any one of the simple product qty input
• Verify the error message display below only invalid qty textbox.

Before: ✖️ 

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@magento run Functional Tests EE, Integration Tests, Static Tests

@magento run all tests

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE, Static Tests

The Functional EE failures in recent 2 builds on same code are not consistent. Failure is neither part of PR nor failing because of the code changes.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39377/37b7fdd34f6bbff04bdbca7380bc15d3/Functional/allure-report-ee/index.html#categories

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39377/8c711180a51292db3d75d57e167b7597/Functional/allure-report-ee/index.html#categories

The Static test failure does not show any error in the Allure report. I checked the Jenkin build's console output; the error is a known issue. It's not part of the PR.
https://jira.corp.adobe.com/browse/AC-13542

@magento run Functional Tests B2B

Hi @Mohamed-Asar,

Thank you for your contribution!

It seems that, the mentioned issue has been recently resolved in 56463d5 under internal JIRA https://jira.corp.adobe.com/browse/ACP2E-3469

It's not reproducible now, hence closing it now. Please feel free to reopen for any further updates.

@engcom-Charlie @engcom-Hotel ,

This is the third time that both the internal team and I have worked on the same issue. Is there a way to avoid this duplication so that I don’t waste time on redundant efforts?

Regarding the code, I reviewed the commit on this line and noticed that the .each function is unnecessary because it loops through all the simple product inputs for every single product. Instead, we should only check the current one, as I’ve implemented in my changes.

If a grouped product contains 10 simple products, the quantity input for each simple product is validated 10 times instead of just once.

Please refer to the screenshot below for verification in the 2.4-develop branch.

vs my branch

@engcom-Charlie @engcom-Hotel ,

This is the third time that both the internal team and I have worked on the same issue. Is there a way to avoid this duplication so that I don’t waste time on redundant efforts?

Regarding the code, I reviewed the commit on this line and noticed that the .each function is unnecessary because it loops through all the simple product inputs for every single product. Instead, we should only check the current one, as I’ve implemented in my changes.

If a grouped product contains 10 simple products, the quantity input for each simple product is validated 10 times instead of just once.

Please refer to the screenshot below for verification in the 2.4-develop branch.

vs my branch

@engcom-Hotel @engcom-Charlie did you get a chance to review this comment ?

@engcom-Hotel @engcom-Charlie did you get a chance to review the last comment ?

Hi @Mohamed-Asar,

Thank you for your contribution!!

Regarding your query on internal team's PR implementation here, we have reached out to the reviewer and following up with the team. Once we get any information on this, we will keep you posted.

Thank you!

Hi @engcom-Charlie,
Thanks! Looking forward for your response

@engcom-Charlie is there any update from internal team ? if no update then please re-open the pr