Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Add UpToDateThemes validator to setup:db:status #39385

Open
m2-assistant bot opened this issue Nov 19, 2024 · 2 comments · May be fixed by #39383
Open

[Issue] Add UpToDateThemes validator to setup:db:status #39385

m2-assistant bot opened this issue Nov 19, 2024 · 2 comments · May be fixed by #39383
Assignees
Labels
feature request Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2024

This issue is automatically created based on existing pull request: #39383: Add UpToDateThemes validator to setup:db:status


Description (*)

Running bin/magento setup:db:status right now does not check whether there is a theme update. If the only change in the deploy is a theme being added, bin/magento setup:db:status will now show;

$ bin/magento setup:db:status
All modules are up to date.

However if you were to run bin/magento setup:upgrade, you'd get this message;

$ bin/magento setup:upgrade
Processing configurations data from configuration file...
The following themes will be registered: frontend/Hyva/Elgentos
Do you want to continue [yes/no]?

With the change in this MR, we'll get this output from setup:db:status;

$ bin/magento setup:db:status
Themes are not up to date
Run 'setup:upgrade' to update your DB schema and data.

Since we rely on the output of setup:db:status to decide whether or not to run setup:upgrade in our deployment pipeline (to make near-zero downtime deployments possible), this is tripping us up from time to time.

This PR aims to add a validator to check whether there are theme changes, forcing setup:upgrade to run.

Thanks to @johnorourke for pointing this out.

@m2-assistant m2-assistant bot linked a pull request Nov 19, 2024 that will close this issue
1 task
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Nov 19, 2024
@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Nov 19, 2024
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 19, 2024
@engcom-Delta engcom-Delta self-assigned this Nov 22, 2024
Copy link
Author

m2-assistant bot commented Nov 22, 2024

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

Hi @peterjaap ,

Thanks for your reporting and collaboration.
It is an improvement so we will mark ticket as feature request.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
Status: Pull Request in Progress
Development

Successfully merging a pull request may close this issue.

3 participants