Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when updating customer email in Admin Panel with ö and .swiss domain #39394

Open
3 of 5 tasks
ouwfuc opened this issue Nov 22, 2024 · 6 comments
Open
3 of 5 tasks
Labels
Area: Account Component: Admin Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev Reported on 2.4.5-p10 Indicates original Magento version for the Issue report. Reported on 2.4.6-p7 Indicates original Magento version for the Issue report. Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@ouwfuc
Copy link

ouwfuc commented Nov 22, 2024

Preconditions and environment

Magento versions tested:

  • 2.4.5-p10
  • 2.4.6-p7
  • 2.4.7

Steps to reproduce

  1. Go to the Admin Panel.
  2. Navigate to Customers > All Customers and select a customer.
  3. In the Account Information section, try to update the email address to something like max@möstermann.swiss.
  4. Save the changes.

Expected result

Email address and customer saved successfully

Actual result

After attempting to save the email, the following error message is displayed at the top of the page:

  • "Email" is not a valid hostname.
  • 'xn--mstermann-07a.swiss' looks like a DNS hostname but we cannot match it against the hostname schema for TLD 'swiss'.
  • 'xn--mstermann-07a.swiss' looks like a local network name, which is not an acceptable format.

Additional information

Observations:

  • When I enter an email like max@möstermann.com, it works fine.
  • When I enter max@möstermann.swiss with the ö, the email is converted to its Punycode equivalent (xn--mstermann-07a.swiss), and the error is triggered.
  • I tried .swiss by itself without the special character ö (e.g., `[email protected]) and it works fine.

It seems like the combination of the ö character and .swiss is causing the issue. The email address gets converted to Punycode, but it seems Magento or the underlying validation logic doesn't handle this combination correctly.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Nov 22, 2024

Hi @ouwfuc. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Nov 22, 2024

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

Hi @ouwfuc ,

Thanks for your reporting and collaboration.
We have verified the issue in Latest 2.4-develop instance and the issue is reproducible. Kindly refer the screenshots.

Steps to reproduce

  1. Go to the Admin Panel.
  2. Navigate to Customers > All Customers and select a customer.
  3. In the Account Information section, try to update the email address to something like max@möstermann.swiss.
  4. Save the changes.
  5. After attempting to save the email, the following error message is displayed at the top of the page:

"Email" is not a valid hostname.
'xn--mstermann-07a.swiss' looks like a DNS hostname but we cannot match it against the hostname schema for TLD 'swiss'.
'xn--mstermann-07a.swiss' looks like a local network name, which is not an acceptable format.

image

Thanks.

@engcom-Delta engcom-Delta added Component: Admin Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Account Reported on 2.4.7 Indicates original Magento version for the Issue report. Reported on 2.4.5-p10 Indicates original Magento version for the Issue report. Reported on 2.4.6-p7 Indicates original Magento version for the Issue report. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Nov 25, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13409 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Nov 25, 2024

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Nov 26, 2024
@Bashev
Copy link
Contributor

Bashev commented Nov 26, 2024

Looks like this issue: laminas/laminas-validator#4 it's in external package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Account Component: Admin Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev Reported on 2.4.5-p10 Indicates original Magento version for the Issue report. Reported on 2.4.6-p7 Indicates original Magento version for the Issue report. Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

5 participants