Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate performance of buffering for GemMappabilityReader #486

Open
magicDGS opened this issue Jul 25, 2018 · 0 comments
Open

Investigate performance of buffering for GemMappabilityReader #486

magicDGS opened this issue Jul 25, 2018 · 0 comments
Labels
Priority: Medium Status: Accepted Accepted in the project backlog Type: Enhancement New features or improved behavior

Comments

@magicDGS
Copy link
Owner

The implementation in #480 is working, but it is reading byte by byte the sequence. A possibility to improve performance is to:

  • Use an internal buffer to maintain cache bytes (using FastLineReader.readToEndOfOutputBufferOrEoln)
  • Change the reader implementation in use (FastLineReader vs. other): I've already tried a BufferedLineReader, but I found problems with eol/eof.
@magicDGS magicDGS added Priority: Medium Type: Enhancement New features or improved behavior Status: Accepted Accepted in the project backlog labels Jul 25, 2018
@magicDGS magicDGS mentioned this issue Jul 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium Status: Accepted Accepted in the project backlog Type: Enhancement New features or improved behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@magicDGS