Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Connect - On IOS, connecting Metamask tru Wallet Connect opens app store #463

Open
3 tasks done
macelai opened this issue Feb 27, 2023 · 3 comments
Open
3 tasks done

Comments

@macelai
Copy link

macelai commented Feb 27, 2023

โœ… Prerequisites

  • Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
  • Are you running the latest SDK version?
  • Are you reporting to the correct repository (magic-sdk)?

๐Ÿ› Description

Using Magic connect, on IOS, connecting Metamask tru Wallet Connect opens app store

๐Ÿงฉ Steps to Reproduce

  1. Connect wallet using Wallet Connect
  2. Choose Metamask

๐Ÿค” Expected behavior

Open Metamask app to connect wallet

๐Ÿ˜ฎ Actual behavior

Open App store

๐Ÿ’ป Code Sample

https://codesandbox.io/s/github/magiclabs/magic-demo-react-web3

๐ŸŒŽ Environment

Software Version(s)
"@magic-ext/connect": "^4.0.0",
"magic-sdk": "^11.0.0",

| Browser | safari
| yarn |
| Operating System | IOS

@macelai
Copy link
Author

macelai commented Feb 27, 2023

My research I found some things that might affect, but as I didn't spend much time investigating magic code, see

https://docs.walletconnect.com/2.0/swift/guides/mobile-linking#ios-app-link-constraints
MetaMask/metamask-mobile#3914

@ayv8er
Copy link

ayv8er commented Mar 9, 2023

Thank you for bringing this up to our attention.
We're currently working on optimizing 3rd party wallet connections to Magic Connect.

@macelai
Copy link
Author

macelai commented Mar 10, 2023

@ayv8er thanks for the response, do you have a sense when it's going to happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants