Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Connect Instagram Browser Error #541

Open
faillacec opened this issue Jun 15, 2023 · 4 comments
Open

Magic Connect Instagram Browser Error #541

faillacec opened this issue Jun 15, 2023 · 4 comments

Comments

@faillacec
Copy link

โœ… Prerequisites

  • [x ] Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
  • [ x] Are you running the latest SDK version?
  • [ x] Are you reporting to the correct repository (magic-sdk)?

๐Ÿ› Description

When try to login with google or email with magic connect it keep loading in auth.magic.link/confirmation-account..

๐Ÿงฉ Steps to Reproduce

  1. Open web app on instagram browser
  2. Try to login with magic using email or google
  3. Magic keep loading in auth.magic.link/confirmation-account..

๐Ÿค” Expected behavior

Successfull connection/login

๐Ÿ˜ฎ Actual behavior

IMG_0446

๐Ÿ’ป Code Sample

๐ŸŒŽ Environment

Software Version(s)
magic-sdk 17.0.0
Browser Instagram browser
yarn NPM
Operating System IOS
@joshuascan
Copy link
Member

Hi,

This issue should be resolved as of our most recent update. Can you confirm if you are still encountering it or if it is working correctly now? I am no longer able to reproduce it on my end. Thanks!

@faillacec
Copy link
Author

Hi,

This issue should be resolved as of our most recent update. Can you confirm if you are still encountering it or if it is working correctly now? I am no longer able to reproduce it on my end. Thanks!

Hi,
I tried login using magic-sdk 17.0.0 and the error persists and I have updated to 18.2.1 version of sdk and the error persists,
This happen just after login when I have to sign a message and this open signature in other browser tab, but in-app-browsers don't have tabs and it keep loading https://auth.magic.link/confirm-action

@joshuascan
Copy link
Member

Hi,

Sorry, I was incorrect in my first response. So we just released a feature that allows for login with signing in one action, which will mitigate the issue you are encountering. You will need to update to v18.4.1 for it.

The docs for it can be found here, under "Login with wallet verification". ConnectWithUI now emits an event that contains an ID token, which can then be validated in your backend using the admin SDK. The previously mentioned docs contain steps for configuration, along with a demo for the frontend portion.

@faillacec
Copy link
Author

Hi,

Sorry, I was incorrect in my first response. So we just released a feature that allows for login with signing in one action, which will mitigate the issue you are encountering. You will need to update to v18.4.1 for it.

The docs for it can be found here, under "Login with wallet verification". ConnectWithUI now emits an event that contains an ID token, which can then be validated in your backend using the admin SDK. The previously mentioned docs contain steps for configuration, along with a demo for the frontend portion.

Hi,
Don't worry, but I am not using this kind of signature i am using Personal signature (https://magic.link/docs/connect/features/personal-signatures) this kind of signature open another tab when click on sign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants