Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add please "button support" for Essential Client #13

Open
ghost opened this issue Jul 5, 2022 · 3 comments
Open

Add please "button support" for Essential Client #13

ghost opened this issue Jul 5, 2022 · 3 comments
Labels
bug Something isn't working mod-interaction

Comments

@ghost
Copy link

ghost commented Jul 5, 2022

2022-07-05_19 54 12

@magicus magicus added bug Something isn't working mod-interaction labels Jul 5, 2022
@magicus
Copy link
Owner

magicus commented Jul 5, 2022

Clearly the placement of our button conflicts with Essential Client. I'm worried this will be a never-ending story, with fixes for mod after mod. I wonder if there is a more general way to inject our button in the menu.

@ghost
Copy link
Author

ghost commented Jul 5, 2022

You could use the option to replace Realms, but this is not the best solution.
I would love if you could add a option to toggle the Button on the title screen and in-game.
This would be the best way (for me), because I just want to reach the menu from in-game and it's not necessary from the title screen. Other way would be, you move the button to the right.
But on the other hand - not many mods adding a extra button to the title screen, the pool is low.

@magicus
Copy link
Owner

magicus commented Jul 6, 2022

That's an interesting idea. I've tried to stay clear of adding options to ModSettings itself, but maybe I have to let go of that, and actually add a setting to determine in which screens the button should be placed... I can see how the title screen button is less useful. (Yet another option is to drop it completely, and just have the in-game button.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mod-interaction
Projects
None yet
Development

No branches or pull requests

1 participant