Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 support #556

Closed
bobvandevijver opened this issue Jan 17, 2025 · 1 comment
Closed

PHP 8.4 support #556

bobvandevijver opened this issue Jan 17, 2025 · 1 comment
Assignees
Labels
dependencies Pull requests that update a dependency file duplicate question

Comments

@bobvandevijver
Copy link
Contributor

bobvandevijver commented Jan 17, 2025

The current release (4.14.0) does not support PHP 8.4, probably because of an outdated php-parser included in the Phar (which is the preferred option to run the analyser).

For example, the following construct fails:

// Lines 111 - 113
return new BadRequest()
  ->addCustomError(sprintf('Requested mailing list %s is not available', $list->name), 'lists')
  ->asResponse($this->serializer);

With the following error:

In LocateASTFromFiles.php line 41:
                                                                               
  Parsing the file [/builds/khY4wW1e/1/group/project/src/Someting/API/MailingList  
  /MailingListApiController.php] resulted in an error: Syntax error, unexpect  
  ed T_OBJECT_OPERATOR, expecting ';' on line 112

Looking at php-parser, an upgrade to at least 5.1.0 is required for the syntax used above, and 5.2.0 for property hook support.

@Ocramius
Copy link
Collaborator

Duplicate of #545

@Ocramius Ocramius marked this as a duplicate of #545 Jan 17, 2025
@Ocramius Ocramius self-assigned this Jan 17, 2025
@Ocramius Ocramius added question duplicate dependencies Pull requests that update a dependency file labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file duplicate question
Projects
None yet
Development

No branches or pull requests

2 participants