-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elevation doesn't work on the NavBarDecoration #12
Comments
Hi, @tushar4303 Thanks for filing the issue. That definitely isn't intended behavior. Feel free to file a PR if you are interested and I will be happy to review it. |
@tushar4303 Upon further investigation I found that this bug is currently in the flutter framework see flutter/flutter#27585 (comment), Unfortunately, we will have to wait until that is fixed rather than pushing some work around. |
Alright, thank you for investigating, i really appreciate your hard work, this package really saved me a ton of time. Also i was wondering, is this package deep Linking ready, or can we expect a feature update for the same. Since i switched from various other options, due to their complexity in setup process. |
@tushar4303 there are no such plans as of now until the package is stabilized with its basic features. However, feel free to file a new issue with all the requested details. I or someone might consider working on it if the proposal sounds plausible. |
Did you try this simple workaround? |
Workarounds like that will add unncessary tech debt. I think we should not add workarounds unless the issue is a severe blocker or affects a lot of users. |
I think that comment only said to wrap the navbar with a top padding... it's not so complicated |
Yes I understand that, but I am guessing it could potential affect the layout of navbar considering we have multiple types of Navbar. |
Your concern is valid, yeah. I'll test that method on different navbar types if I have free time and tell you the result. Thanks! |
who fix this issue |
The background behind the navigation bar and the bottom nav bar are both white in my UI, which makes it really hard to notice the navbar's starting point and the elevation doesn't seem to work in order to add the shadow to the navbar
Steps to reproduce the behavior:
Expected behavior
A shadow should have appeared at the top of the NavBar
Screenshots
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: