Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevation doesn't work on the NavBarDecoration #12

Open
tushar4303 opened this issue Dec 22, 2022 · 10 comments
Open

Elevation doesn't work on the NavBarDecoration #12

tushar4303 opened this issue Dec 22, 2022 · 10 comments
Labels
bug Something isn't working flutter Issues blocked due to bug in the flutter framework P2 Something does not work as expected and needs a fix

Comments

@tushar4303
Copy link

The background behind the navigation bar and the bottom nav bar are both white in my UI, which makes it really hard to notice the navbar's starting point and the elevation doesn't seem to work in order to add the shadow to the navbar

Steps to reproduce the behavior:

  1. Changing value on the elevation property doesn't make ui shadow show up

Expected behavior
A shadow should have appeared at the top of the NavBar

Screenshots

Smartphone (please complete the following information):

  • Device: [Redmi Note 11]
  • OS: [Android ]
  • Version [12]
@maheshj01 maheshj01 added the in triage This issue is currently being triaged label Dec 22, 2022
@maheshj01
Copy link
Owner

Hi, @tushar4303 Thanks for filing the issue. That definitely isn't intended behavior. Feel free to file a PR if you are interested and I will be happy to review it.

@maheshj01 maheshj01 added bug Something isn't working easy fix should take couple of hours to fix and removed in triage This issue is currently being triaged labels Dec 22, 2022
@maheshj01
Copy link
Owner

maheshj01 commented Dec 23, 2022

@tushar4303 Upon further investigation I found that this bug is currently in the flutter framework see flutter/flutter#27585 (comment), Unfortunately, we will have to wait until that is fixed rather than pushing some work around.

@maheshj01 maheshj01 added flutter Issues blocked due to bug in the flutter framework and removed easy fix should take couple of hours to fix labels Dec 23, 2022
@tushar4303
Copy link
Author

Alright, thank you for investigating, i really appreciate your hard work, this package really saved me a ton of time.

Also i was wondering, is this package deep Linking ready, or can we expect a feature update for the same.

Since i switched from various other options, due to their complexity in setup process.

@maheshj01
Copy link
Owner

@tushar4303 there are no such plans as of now until the package is stabilized with its basic features. However, feel free to file a new issue with all the requested details. I or someone might consider working on it if the proposal sounds plausible.

@maheshj01 maheshj01 added the P2 Something does not work as expected and needs a fix label Jun 21, 2023
@bebaoboy
Copy link
Contributor

@tushar4303 Upon further investigation I found that this bug is currently in the flutter framework see flutter/flutter#27585 (comment), Unfortunately, we will have to wait until that is fixed rather than pushing some work around.

Did you try this simple workaround?
Issue comment

@maheshj01
Copy link
Owner

Workarounds like that will add unncessary tech debt. I think we should not add workarounds unless the issue is a severe blocker or affects a lot of users.

@bebaoboy
Copy link
Contributor

I think that comment only said to wrap the navbar with a top padding... it's not so complicated

@maheshj01
Copy link
Owner

Yes I understand that, but I am guessing it could potential affect the layout of navbar considering we have multiple types of Navbar.

@bebaoboy
Copy link
Contributor

Your concern is valid, yeah. I'll test that method on different navbar types if I have free time and tell you the result. Thanks!

@RashkaDahir
Copy link

who fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flutter Issues blocked due to bug in the flutter framework P2 Something does not work as expected and needs a fix
Projects
None yet
Development

No branches or pull requests

4 participants