Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update critical flows with e2e test coverage #61

Open
1 of 3 tasks
jeffpaul opened this issue Sep 24, 2024 · 4 comments · May be fixed by #87
Open
1 of 3 tasks

Update critical flows with e2e test coverage #61

jeffpaul opened this issue Sep 24, 2024 · 4 comments · May be fixed by #87
Assignees
Labels
needs:qa This requires QA testing. needs:tests This requires tests. type:task The issue is an internally driven task.
Milestone

Comments

@jeffpaul
Copy link
Collaborator

Is your enhancement related to a problem? Please describe.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jeffpaul jeffpaul added needs:qa This requires QA testing. needs:tests This requires tests. type:task The issue is an internally driven task. labels Sep 24, 2024
@jeffpaul jeffpaul added this to the 1.7.0 milestone Sep 24, 2024
@MaxwellGarceau MaxwellGarceau self-assigned this Dec 21, 2024
@MaxwellGarceau
Copy link
Collaborator

Progress and notes tracked on Teamwork task.

@MaxwellGarceau
Copy link
Collaborator

MaxwellGarceau commented Jan 3, 2025

@jeffpaul would it be possible to get credentials to the Mailchimp user account the CI/CD Github action pipeline uses? I need to generate a Mailchimp API token for the user that can be used in a few of the tests in order to programmatically change the account options to replicate the scenarios we're testing for.

In addition, I'd like to add a second Mailchimp user account that's necessary for a few test cases to A/B that user settings are saving in WordPress correctly.

Plans to wrap up the E2E testing

  • Update the Github repo with the credentials that the tests require (or pass these credentials to someone with Github secrets privileges)
  • Ensure all E2E tests are passing
  • Update the Github wiki critical flow testing documentation with the exact status of which flows are represented by E2E tests. Highlight expectations that can not be replicated in E2E tests due to current blockers and note the blocker.
  • (if time) Fix bug causing conditional logging in to Mailchimp account to initiate on every test file. This should only need to happen once at the beginning of the test run
    • (Alternative) Remove conditional login, ensure that the user logs in at the beginning of a test suite run, and document that E2E test files can not be run separately

@jeffpaul
Copy link
Collaborator Author

jeffpaul commented Jan 3, 2025

@justin0440 can you confirm if there's a repo secret for an API key? I know we have one created for our testing account, but not sure if that was added as a repo secret. If there's no secret, then I'll DM you the API key to add as a secret for @MaxwellGarceau to then use here.

@dkotter
Copy link
Collaborator

dkotter commented Jan 3, 2025

There are two secrets we use for E2E tests: MAILCHIMP_USERNAME and MAILCHIMP_PASSWORD, though I don't know what values are set there (if it's from our account or something else).

One thing to be cautious of is any API rate limits that we may run into when using those credentials in automated tests. That may not be a concern here but I know from past experience, you can easily hit limits if making actual authenticated API requests in pipelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:qa This requires QA testing. needs:tests This requires tests. type:task The issue is an internally driven task.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants