Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email adapter have different blocking behavior #25

Open
Musashi178 opened this issue Oct 5, 2015 · 1 comment
Open

Email adapter have different blocking behavior #25

Musashi178 opened this issue Oct 5, 2015 · 1 comment

Comments

@Musashi178
Copy link

Hi,

I noticed that the TestAdapter will do a non-blocking cast for delivering emails, but other adapters will do a blocking call. This causes different handling of the deliver result depending whether I am running my tests or being in dev or production mode. They all should be either blocking or non-blocking.

@skosch
Copy link
Collaborator

skosch commented Sep 22, 2017

In fact, I think it would be nice if we offered more flexibility, similar to what thoughbot's bamboo library is doing (blocking, non-blocking, optional delays, etc. are all useful to have depending on the situation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants