From 5c2e1f41a448c4a77dc31afb09bb01b521e626e0 Mon Sep 17 00:00:00 2001 From: Thang Hoang Van Date: Tue, 5 Sep 2023 19:34:14 +0700 Subject: [PATCH] Fixed: codefactor issues Update: readme --- class/class-mainwp-child-actions.php | 2 +- class/class-mainwp-child-misc.php | 4 ++-- class/class-mainwp-pages.php | 2 +- readme.txt | 6 ++++++ 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/class/class-mainwp-child-actions.php b/class/class-mainwp-child-actions.php index 87517fc6..eb87b199 100644 --- a/class/class-mainwp-child-actions.php +++ b/class/class-mainwp-child-actions.php @@ -379,7 +379,7 @@ public function callback_upgrader_process_complete( $upgrader, $extra ) { // php $old_version = $old_theme['version']; } } elseif ( ! empty( $upgrader->skin->theme_info ) ) { - $old_version = $upgrader->skin->theme_info->get( 'Version' ); // to fix old version //$theme['Version']; + $old_version = $upgrader->skin->theme_info->get( 'Version' ); // to fix old version //$theme['Version']. } $version = $theme_data['Version']; diff --git a/class/class-mainwp-child-misc.php b/class/class-mainwp-child-misc.php index 9e116042..953ae201 100644 --- a/class/class-mainwp-child-misc.php +++ b/class/class-mainwp-child-misc.php @@ -603,7 +603,7 @@ public function uploader_upload_file( $file_url, $path, $file_name ) { /** - * @credit WordPress. + * * Sanitizes a filename, replacing whitespace with dashes. * * Removes special characters that are illegal in filenames on certain @@ -614,7 +614,7 @@ public function uploader_upload_file( $file_url, $path, $file_name ) { * filename that is allowed to be uploaded. * * @since 2.1.0 - * + * @credit WordPress. * @param string $filename The filename to be sanitized. * @return string The sanitized filename. */ diff --git a/class/class-mainwp-pages.php b/class/class-mainwp-pages.php index bff8c728..b99fbe77 100644 --- a/class/class-mainwp-pages.php +++ b/class/class-mainwp-pages.php @@ -383,7 +383,7 @@ public static function render_header( $shownPage, $subpage = true, &$show_clone_ if ( $connected ) { $current_user = wp_get_current_user(); if ( $current_user ) { - $is_connected_admin = $current_user->user_login === get_option( 'mainwp_child_connected_admin' ) ? true : false; + $is_connected_admin = get_option( 'mainwp_child_connected_admin' ) === $current_user->user_login ? true : false; } } $show_clone_funcs = $connected && $is_connected_admin ? true : false; diff --git a/readme.txt b/readme.txt index 64d0f660..21799160 100644 --- a/readme.txt +++ b/readme.txt @@ -164,6 +164,12 @@ Yes, we have a quick FAQ with a lot more questions and answers [here](https://ma == Changelog == += 4.5.1 - 9-5-2023 = +* Fixed: Problem with loading tabs content on the MainWP Child settings page +* Fixed: An issue with selecting Clone options +* Fixed: Usability problem with file name sanitation for the File Uploader +* Updated: Removed clone options for all users except for the Admin user that is used for establishing the connection with the MainWP Dashboard + = 4.5 - 8-15-2023 = * Added: Support for alternative OpenSSL signature verification algorithm * Added: PHPSecLib as a fallback for missing or Misconfigured OpenSSL