From 5db9d76e59a0e5c4263cfa3d7bb616de2a5adcbe Mon Sep 17 00:00:00 2001 From: Steve8291 Date: Thu, 14 Nov 2024 08:19:34 -0500 Subject: [PATCH 1/2] Fix option "prettyicon" mysqltuner.pl Added option "prettyicon" along with "noprettyicon". Defaults to noprettyicon. Updated --help menu. Fixes error message "Use of uninitialized value $opt{"prettyicon"} in numeric ne (!=) at mysqltuner.pl line 236" --- mysqltuner.pl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 6af4f5e3..7c6d06b7 100755 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -118,6 +118,7 @@ package main; "feature" => '', "dbgpattern" => '', "defaultarch" => 64, + "prettyicon" => 0, "noprettyicon" => 0 ); @@ -155,7 +156,8 @@ package main; 'defaults-extra-file=s', 'dumpdir=s', 'feature=s', 'dbgpattern=s', 'defaultarch=i', 'experimental', - 'nondedicated', 'noprettyicon' + 'nondedicated', 'prettyicon', + 'noprettyicon' ) or pod2usage( -exitval => 1, @@ -233,7 +235,8 @@ package main; $opt{cvefile} = 'vulnerabilities.csv'; #CVE File for vulnerability checks } -$opt{prettyicon}=0 if $opt{prettyicon}!=1; +$opt{prettyicon} = 0 if $opt{prettyicon}!=1; +$opt{prettyicon} = 0 if ( $opt{noprettyicon} == 1 ); $opt{nocolor} = 1 if defined( $opt{outputfile} ); $opt{tbstat} = 0 if ( $opt{notbstat} == 1 ); # Don't print table information $opt{colstat} = 0 if ( $opt{nocolstat} == 1 ); # Don't print column information @@ -7506,6 +7509,7 @@ =head1 OUTPUT OPTIONS --verbose Print out all options (default: no verbose, dbstat, idxstat, sysstat, tbstat, pfstat) --color Print output in color --nocolor Don't print output in color + --prettyicon Print output with new icons: ✔, ✘, ℹ, ⚙, ⌨️, ... --noprettyicon Print output with legacy tag [OK], [!!], [--], [CMD], ... --nogood Remove OK responses --nobad Remove negative/suggestion responses From d1c4e49593e151c59bc365234261814f139e0fcf Mon Sep 17 00:00:00 2001 From: Steve8291 Date: Thu, 14 Nov 2024 08:26:07 -0500 Subject: [PATCH 2/2] Fix options "prettyicon" and "noprettyicon" Added option "prettyicon" along with "noprettyicon". Defaults to noprettyicon. Updated --help menu. Fixes error message "Use of uninitialized value $opt{"prettyicon"} in numeric ne (!=) at mysqltuner.pl line 236" --- mysqltuner.pl | 1 - 1 file changed, 1 deletion(-) diff --git a/mysqltuner.pl b/mysqltuner.pl index 7c6d06b7..2154b556 100755 --- a/mysqltuner.pl +++ b/mysqltuner.pl @@ -235,7 +235,6 @@ package main; $opt{cvefile} = 'vulnerabilities.csv'; #CVE File for vulnerability checks } -$opt{prettyicon} = 0 if $opt{prettyicon}!=1; $opt{prettyicon} = 0 if ( $opt{noprettyicon} == 1 ); $opt{nocolor} = 1 if defined( $opt{outputfile} ); $opt{tbstat} = 0 if ( $opt{notbstat} == 1 ); # Don't print table information