Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot allow self signed certificates with current httpClient access level #3

Open
DavidBrunow opened this issue Apr 21, 2023 · 0 comments

Comments

@DavidBrunow
Copy link

DavidBrunow commented Apr 21, 2023

I'm using this library with an internal GitLab enterprise instance that is using a self-signed certificate. Without adjusting the access level of the GLApis httpClient to public I cannot set the security on that client to .acceptSelfSigned. Here is where I make that change for our use: https://github.com/malcommac/GitLabSwift/blob/main/Sources/GitLabSwift/Core/GLApi.swift#L76

I don't think that the best answer is to make that httpClient public but some way to influence the security would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant