Fixes IgnMonitor bug. #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalbachicar
requested changes
Mar 5, 2021
| // Ignition subscriber callback, updating state | ||
| // and notify all threads waiting on this instance. | ||
| // | ||
| // @param message Message received. | ||
| void OnTopicMessage(const IGN_TYPE& message) { | ||
| // A std::shared_ptr to `this` is created in order to guarantee | ||
| // that the IgnMonitor instance isn't destroyed for |
There was a problem hiding this comment.
isn't --> hasn't been already
for --> at
agalbachicar
previously approved these changes
Mar 5, 2021
| // @param A pointer to this instance. | ||
| // @throws std::logic_error When `self_ptr.get()` != `this`. | ||
| void Initialize(std::shared_ptr<IgnMonitor<IGN_TYPE>> self_ptr) { | ||
| DELPHYNE_VALIDATE(self_ptr.get() == this, std::logic_error, "self_ptr must point at `this` instance."); |
There was a problem hiding this comment.
Nit: must point at --> must point to
agalbachicar
previously approved these changes
Mar 5, 2021
francocipollone
force-pushed
the
francocipollone/fix_agent_simulation_builder_test
branch
from
f2aab02
to
470523c
Compare
|
Sorry @agalbachicar, I had to push again. No changes since the last review. |
francocipollone
deleted the
francocipollone/fix_agent_simulation_builder_test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #751
IgnMonitorclass subscribes a callback method to a topic.Ignition-transport7doesn't guarantee that the callback method is executed while the instance of the class is still alive.The callback method being called after the instance was destroyed used to happen randomly in CI when stressed.
To solve that lack of synchronization we introduce a
std::share_ptrof the IgnMonitor class into the callback method.See #751 for further information.