Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random adjacency matrices do not affect the performance #32

Open
zhanqiuzhang opened this issue Jul 18, 2021 · 1 comment
Open

Random adjacency matrices do not affect the performance #32

zhanqiuzhang opened this issue Jul 18, 2021 · 1 comment

Comments

@zhanqiuzhang
Copy link

Hi, thanks for sharing the code!

I find that after randomly breaking the adjacency matrices, the performance of CompGCN remains unchanged (0.334, DistMult+multiplication). The codes in run.py that I have changed are as follows.

for sub, rel, obj in self.data['train']:
    obj = random.randint(0, self.p.num_ent)
    edge_index.append((sub, obj))
    edge_type.append(rel)

# Adding inverse edges
for sub, rel, obj in self.data['train']:
    obj = random.randint(0, self.p.num_ent)
    edge_index.append((obj, sub))
    edge_type.append(rel + self.p.num_rel)

Did I have any misunderstanding about the codes?

@nguyenhungquang
Copy link

I think the main contribution to performance is the decoder. I tried to remove convolution layer but still obtain similar results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants