Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include bin hash in cache key #228

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Conversation

bhperry
Copy link
Contributor

@bhperry bhperry commented Sep 30, 2024

Add sha256 hash of the micromamba binary to the cache key so broken environments created from previous versions won't be restored for a new version.

Closes #91

src/cache.ts Outdated Show resolved Hide resolved
@pavelzw
Copy link
Member

pavelzw commented Oct 1, 2024

Could you also compile the action and bump its version in package.json?

Co-authored-by: Pavel Zwerschke <[email protected]>
@bhperry
Copy link
Contributor Author

bhperry commented Oct 1, 2024

Could you also compile the action and bump its version in package.json?

@pavelzw minor bump for this?

@pavelzw
Copy link
Member

pavelzw commented Oct 1, 2024

Sure 👍🏻

@bhperry
Copy link
Contributor Author

bhperry commented Oct 1, 2024

Is test.sh outdated? Tried to run it, but no index.js in dist

@pavelzw pavelzw added the enhancement New feature or request label Oct 1, 2024
@pavelzw
Copy link
Member

pavelzw commented Oct 1, 2024

Yes seems like it 🤔 I nowadays just run the tests from GitHub ci

@pavelzw
Copy link
Member

pavelzw commented Oct 1, 2024


Error: src/cache.ts(43,22): error TS2339: Property 'readBinaryFile' does not exist on type 'typeof import("fs/promises")'.

@bhperry
Copy link
Contributor Author

bhperry commented Oct 1, 2024

hmm looked that one up somewhere, guess I was looking at the wrong fs package

@bhperry
Copy link
Contributor Author

bhperry commented Oct 1, 2024

seems like regular readFile with no encoding should do the trick

@pavelzw
Copy link
Member

pavelzw commented Oct 2, 2024

The ci failures look unrelated. I'll take a look at them later

@pavelzw
Copy link
Member

pavelzw commented Oct 2, 2024

the remaining failing ci is tracked in #230

@pavelzw pavelzw merged commit 59b1132 into mamba-org:main Oct 2, 2024
62 of 63 checks passed
@bhperry bhperry deleted the bin-cache-key branch October 2, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add micromamba version to cache key?
2 participants