Harden against object lifetime on exceptions #1928
Conversation
willdealtry
changed the title
willdealtry
force-pushed
the
chaos_testing
branch
from
861cd22
to
5d08d65
Compare
cpp/arcticdb/CMakeLists.txt
Outdated
| @@ -954,7 +954,7 @@ if(${TEST}) | |||
| python/python_handlers.cpp | |||
| storage/test/common.hpp | |||
| version/test/test_sort_index.cpp | |||
| ) | |||
| util/test/random_throw.hpp) | |||
There was a problem hiding this comment.
nit: alphabetical order
cpp/arcticdb/async/tasks.hpp
Outdated
| @@ -507,6 +510,7 @@ struct MemSegmentFunctionTask : BaseTask { | |||
| ARCTICDB_MOVE_ONLY_DEFAULT(MemSegmentFunctionTask) | |||
|
|
|||
| folly::Unit operator()(std::pair<VariantKey, SegmentInMemory> &&seg_pair) { | |||
| ARCTICDB_DEBUG_THROW(5) | |||
There was a problem hiding this comment.
This task is unused, assume this should be in MemSegmentProcessingTask
cpp/arcticdb/processing/clause.cpp
Outdated
| @@ -100,6 +100,7 @@ std::vector<EntityId> PassthroughClause::process(std::vector<EntityId>&& entity_ | |||
| } | |||
|
|
|||
| std::vector<EntityId> FilterClause::process(std::vector<EntityId>&& entity_ids) const { | |||
| ARCTICDB_DEBUG_THROW(5) | |||
There was a problem hiding this comment.
Could just stick this in the base class to avoid the duplication
https://github.com/man-group/ArcticDB/blob/master/cpp/arcticdb/processing/clause.hpp#L59-L61
And could put one in the structure_for_processing overload that takes entity_ids_vec as well for good measure.
| @@ -1435,10 +1435,10 @@ VersionedItem collate_and_write( | |||
| }); | |||
| } | |||
|
|
|||
| void delete_incomplete_keys(PipelineContext* pipeline_context, Store* store) { | |||
| void delete_incomplete_keys(PipelineContext& pipeline_context, Store& store) { | |||
There was a problem hiding this comment.
Guessing PipelineContext can be const&
There was a problem hiding this comment.
A rational person would think so, but because of irritating reasons the function returning the iterator into the pipeline context can't be made easily const, and we want this class to just go away so I don't want to spend too much time (any time) polishing it.
willdealtry
force-pushed
the
chaos_testing
branch
from
5d08d65
to
1da3a6a
Compare
Throw from pipeline and storages to check resiliency