Lib tool upgrades 44x #1934
Draft
Lib tool upgrades 44x #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoDD
force-pushed
the
lib-tool-upgrades-44x
branch
3 times, most recently
from
9fb9716
to
217201d
Compare
#### Reference Issues/PRs Implements #1391 and fixes #1532. - Added read_index in LibraryTool (as required in #1391) - Allowed Library to get LibraryTool and call read_index (to fix #1532). Also updated the docs accordingly. #### What does this implement or fix? #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing -->
- Fixes reading correct index value for timestamps - Fixes reading VERSION_REF keys - Adds elaborate tests for iterating the version chain
Does this by adding a cpp layer functionality to overwrite append data keys. And using a read + type change + overwrite in the python layer. More specifically this change involves: - Using a `LocalVersionEngine` instead of an `AsyncStore` as library tool state - Exposing some more python bindings to allow iteration over `APPEND_DATA` keys with the library tool - Allow using normalization in library tool to allow overwriting append data keys with a custom dataframe - Provide the type change functionality by reading a dataframe, changing its type with pandas and overwriting it - Adds an elaborate test to verify iterating and reading append data linked list is fine with various overwrites.
- Replaces a few function calls with their old names - Removes some timeseries descriptor bindings exposed
IvoDD
force-pushed
the
lib-tool-upgrades-44x
branch
from
217201d
to
cc6fb57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #1533, #1832 and #1932 to 4.4.x
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...