Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string: deduplicate comparison logic between string and string_view #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

string: deduplicate comparison logic between string and string_view #53

wants to merge 1 commit into from

Conversation

qookei
Copy link
Member

@qookei qookei commented Oct 29, 2022

Fixes #36.

@qookei qookei requested a review from ArsenArsen October 29, 2022 22:29
@ArsenArsen
Copy link
Member

What do you think of implementing the spaceship operator?

@qookei
Copy link
Member Author

qookei commented Oct 30, 2022 via email

ArsenArsen
ArsenArsen approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@ArsenArsen ArsenArsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be okay with the spaceship added (and that was agreed upon), approving ahead of november

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArsenArsen ArsenArsen ArsenArsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deduplicate parts of code between basic_string and basic_string_view
2 participants
@qookei @ArsenArsen