Chocolatey is unable to resolve Chrome's path

[d35ha]

It seems chocolatey is not able to resolve this path:

VM-Packages/packages/cyberchef.vm/tools/chocolateyinstall.ps1

Line 28 in 5efa360

$iconLocation = "%ProgramFiles%\Google\Chrome\Application\chrome.exe"

[d35ha]

Fixed at 4951414.

[Ana06]

@d35ha I think there is no PR for that change, so this is not fixed. Or am I missing something?

[emtuls]

@Ana06 @d35ha

I believe this issue is related to a Google Chrome installation failure which occurs when Github Actions images are updated to use the latest chrome version (this happens periodically), and we cannot install our googlechrome.vm package (which uses the latest version) because it is already installed.

When the image that is used by Github Actions updates to use the latest Google Chrome, an error occurs with the googlechrome.vm installation because the same version is already installed, thus causing the package to fail to install.

When this package fails to install, it also causes an error for other packages that depend on googlechrome.vm, one of those being cyberchef.vm. When googlechrome.vm is not installed, the path to the browser is not in the location we expect, which also causes a failure for finding the icon in the path we are using.
This particular part of the issue will be resolved when we change the icon for CyberChef to be something other than Google Chrome in this PR: #1054

See error below for what I mean by googlechrome.vm failing to install in the latest run. The image was recently updated to use the latest chrome browser, which can be seen here:
Github Action Image Info - https://github.com/actions/runner-images/releases/tag/win22%2F20240912.1
Google Chrome Versioning - https://chromiumdash.appspot.com/releases?platform=Windows)

This issue has been noted in other areas as an issue that can occur: yarnpkg/yarn#1647 (comment)

[Ana06]

@emtuls the error you mention does not only happen in GH actions, also if you have Chrome already installed. As mentined in #1138, we need to add valid exit codes to fix that issue as we do with other installers. But I think the error @d35ha mentions here is different as the package does not fail to install.

[Ana06]

I think Chrome and CyberChef are working correctly and that the issue does not happen anymore. Please @d35ha re-open it if it still happens.