Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mangahere] random invalid URL #966

Open
Sheepux opened this issue Jan 5, 2025 · 12 comments
Open

[Mangahere] random invalid URL #966

Sheepux opened this issue Jan 5, 2025 · 12 comments
Assignees

Comments

@Sheepux
Copy link
Contributor

Sheepux commented Jan 5, 2025

Using link paste
https://www.mangahere.cc/manga/lord_of_goblins/
Any chapter : unable to preview

Behavior is incosistent, sometimes it works but when it fails it's persistent for a good while

DM5.ts:75 Uncaught (in promise) TypeError: Failed to construct 'URL': Invalid URL
at DM5.ts:75:54
at MangaHere_default.FetchPagesSinglePageScript (DM5.ts:75:19)
at async Chapter.Update (MediaPlugin.ts:96:34)

At the same time works fine in hakuneko

I'm unable to see http traffic for mangahere in network console (I was able in haku)

Edit: trying to browse mangahere from the internal browser is suddenly slow browsing the website. Works fine in the OS browser
Still investigating

Edit2: website is now also slow within the OS browser. Possibly related to an IP throttling mechanism

@MikeZeDev
Copy link
Contributor

MikeZeDev commented Jan 6, 2025

I got errors on mangahere in mihon too and people complained on discord. In Browser pages load then randomly dont load, i dont think is from us.

@Sheepux
Copy link
Contributor Author

Sheepux commented Jan 6, 2025

yeah that's the conclusion i'm reaching, their website doesn't seem stable

@Sheepux
Copy link
Contributor Author

Sheepux commented Jan 6, 2025

However, the message is "un-understandable". Invalid URL doesn't tell much

@MikeZeDev
Copy link
Contributor

MikeZeDev commented Jan 7, 2025

You have no network activity shown because its an injected script and not a direct Fetch. Pages are eval(packed) in chapter , we have to do that.

And for the message, well, its default Javascript error returned from failed promise. Since executing JS is a blackbox its better to have the real JS error than an obscure "cant get pages bro". Its sad fro users tho 🤷 .

Perhaps it could be improved : "Cant get pages : <error>"

In browser and haru ive seen the infamous "Sorry" Cloudflare page from their CDN, its a CDN problem.
Remember it will also affect websites that hotlinks from mangahere like Mangatown

@Sheepux
Copy link
Contributor Author

Sheepux commented Jan 20, 2025

Morning attempt, website is working fine. Haruneko is stable.
Note for self :
haku is processing for 4s while the website itself loads in less than 1 seconds. An optimisation could be investigated.

@MikeZeDev
Copy link
Contributor

Depends on what you mean by processing. We have to open a browser window , execute some JS, and stuff. If you add the necessary delays perhaps its not abnormal.

@Sheepux
Copy link
Contributor Author

Sheepux commented Jan 20, 2025

It was almost instant before. Something changed that might be delaying something (both in haku & haru)

@MikeZeDev
Copy link
Contributor

You realize that something couldnt have changed in haku? related code shouldnt have changes for ages afaik.
I just tried, in kinda instant.

@Sheepux
Copy link
Contributor Author

Sheepux commented Jan 20, 2025

Not on my side. This is issue is for myself/investigation

@MikeZeDev
Copy link
Contributor

In Haku i can see some slowness on FetchUI for some manga but we didnt change fetchui. Perhaps they added more crappy ads/scripts on the website idk. It could slow down Haru too..

@Sheepux
Copy link
Contributor Author

Sheepux commented Jan 20, 2025

therefore this PR but it didn't solve. That's why there is this thread: something changed on their side (i'm using a locally non refreshed git clone in haku), I still don't know what.

@MikeZeDev
Copy link
Contributor

If you ever find a manga where we can reproduce that, tell me. I had one but i forgot to note its name.

@Sheepux Sheepux self-assigned this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants