Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use css-flags #60

Open
pixelastic opened this issue Jun 22, 2016 · 2 comments
Open

Re-use css-flags #60

pixelastic opened this issue Jun 22, 2016 · 2 comments

Comments

@pixelastic
Copy link

Awesome project,

Maybe you would be interested in css-flags (repo) where I did 170 flags with one div :)

image

I'd be happy to contribute, but copy-pasting the code form one repo to another won't be the most effective way to maintain it. Maybe just a link between projects, or a git submodule?

@manrajgrover
Copy link
Owner

@pixelastic Hey! This is so cool! 😄

We should definitely have section linking to awesome Single Div repositories/sections. But we already have a section for flags. I see there are already overlapping flags. Please share your view on how to proceed. 😊

@pixelastic
Copy link
Author

There are several ways to do the same flag, so it's always nice to see how others did it.

The best (for me), would be to have a link to css-flags in your readme (and I can do the same in mine), and people can create PR for missing flags in css-flags. That would mean removing all the nice other implementations you already have.

So maybe just a note saying that if people want to add a new flag, maybe check on css-flags if it wasn't already done? I don't have any strong opinion on the subject :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants