Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flagpack gradient and shadow? #2

Open
Geczy opened this issue Jan 20, 2023 · 4 comments
Open

flagpack gradient and shadow? #2

Geczy opened this issue Jan 20, 2023 · 4 comments

Comments

@Geczy
Copy link

Geczy commented Jan 20, 2023

how do we take advantage of the original flagpack options?

https://flagpack.xyz/docs/design/#styles

https://www.npmjs.com/package/react-flagpack

hoping for all props to become available

image

image

image

@rtivital
Copy link
Member

It is not planned to introduce these features as they might increase bundle size significantly or mess up with tree-shaking

@Geczy
Copy link
Author

Geczy commented Jan 20, 2023

why would it increase bundle size or mess up tree shaking? these are just css classes

see here https://github.com/Yummygum/react-flagpack/blob/main/src/Flag.scss#L100

and usage here https://github.com/Yummygum/react-flagpack/blob/main/src/Flag.tsx#L27

@Geczy
Copy link
Author

Geczy commented Jan 24, 2023

@rtivital any update?

@rtivital
Copy link
Member

I'm not planning to work on this any time soon. If you want this feature, you are welcome to submit a PR. Note that you will need to test that tree shacking works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants