Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Title of the embed when link is shared in Discord. #2793

Closed
PhantomKnight287 opened this issue Oct 25, 2022 · 5 comments
Closed

Incorrect Title of the embed when link is shared in Discord. #2793

PhantomKnight287 opened this issue Oct 25, 2022 · 5 comments
Labels
Fixed Completed issues that will be published with next patch (1.0.X)

Comments

@PhantomKnight287
Copy link
Contributor

Link to the page where something nasty is located

https://mantine.dev

Exact quote of what is wrong

If you share this link https://mantine.dev on discord, the embed shows the title AppShell Demo instead of Mantine.

image

Are you willing to create pull request with the fix?

No response

@rtivital rtivital added help wanted Contributions from community are welcome and removed review required labels Oct 25, 2022
@LeHvass
Copy link

LeHvass commented Oct 25, 2022

Hi @rtivital,

I've been able to recreate this in production and locally with npm run docs:build (see images).
Screenshot 2022-10-25 at 19 19 25
Screenshot 2022-10-25 at 18 44 52

However, issue appears to be inconsistent (doesn't happen on every build) and related to some kind of race condition.

A very similar sounding issue with the gatsy-plugin-material-ui package was being discussed here hupe1980/gatsby-plugin-material-ui#80 (comment).

@rtivital, it seems like the issue is likely with the gatsy-ssr.js file, but I am personally unsure how to proceed. If this turns out to be difficult and/or time consuming to nail down, we may be better off moving to the new Gatsby Head API as the gatsby-plugin-react-helmet is anyway to be deprecated. (Would require moving gatsby package from 4.14 to at least 4.19 (current version 4.24).
Screenshot 2022-10-25 at 18 59 50

What are your thoughts?

@rtivital
Copy link
Member

I would rather migrate to new Gatsby Head API, it would be great if you can send a PR

@LeHvass
Copy link

LeHvass commented Oct 26, 2022

I'm unsure when I'll have the bandwidth to look at this, so for now, let's leave it open for anyone to jump on.

@rtivital
Copy link
Member

Okay, help is still wanted then

@rtivital rtivital removed the help wanted Contributions from community are welcome label Nov 12, 2022
@rtivital rtivital added the Fixed Completed issues that will be published with next patch (1.0.X) label Dec 7, 2022
@rtivital
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

3 participants