Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "responsive" Header examples unless they are usable on all viewport sizes #49

Open
montchr opened this issue Feb 8, 2023 · 0 comments

Comments

@montchr
Copy link

montchr commented Feb 8, 2023

Only one two of the Header examples actually work on small viewports, and yet there are "twelve" "responsive" components. This feels very misleading and confusing. What's more is that it's entirely unclear which of these components has a menu toggle that works at smaller viewport widths.

At first I thought every menu in the Header components was broken and came here to look for bug reports, but after finding #37 I see that this is apparently expected behavior. As a prospective user of the library, it makes me question the integrity of the other components in Mantine: i.e. am I going to be unpleasantly surprised to find that something else doesn't work as it would appear on the surface?

Regardless of whether the headers are labelled "responsive" or not: what is the point of collapsing a menu behind a toggle button on mobile if the toggle button does nothing at all? I would suggest removing the non-functional components entirely until they can be re-introduced with the functionality implied by the menu toggle button. Otherwise, the examples aren't really showing anything interesting at all – it's easy to toggle the state of an icon, but mobile navigation is hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant