Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rrd-extractstats.pl needs sort on %knownlinks & requires statsfile to be deleted if knownlinks file has changed #96

Open
hengchai opened this issue Dec 1, 2020 · 1 comment

Comments

@hengchai
Copy link

hengchai commented Dec 1, 2020

  1. With the addition of skipifnotmodified, the stats table is no longer being re-created during every run. However, function read_knownlinks() loads all the links into a hash %knownlinks which has inconsistent sort order when it's filled into @links.

Quick fix for is to update line 41:

my @links = values %knownlinks;

to

my @links = sort values %knownlinks;

This will keep the list of links consistent across runs.

  1. Per above, since stats table is no longer recreated during every run, if there's a new link added (or removed) the statsfile needs to be deleted so that rrd-extractstats.pl will recreate. Ideally schema should be checked to identify if there's any new links added (or removed).
@pv2b
Copy link
Contributor

pv2b commented Apr 24, 2023

I've made a pull request for this exact issue, see #105. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants