chore: add typescript build and sourcemaps #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, but next time please wait for maintainer's willingness to accept a drastic change to their library before doing the actual work. I'm not interested in maintaing Earcut in TypeScript form at this moment. I might consider adding first-class TS types via JSDoc at some point like in some of my other libraries, but would like to do it myself because I'm very sensitive to details when it comes to maintenance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #164
I had to change the test runner to vitest because node test runner doesn't support testing TypeScript files.
I also couldn't get the ESLint script to work because the
eslint-config-mournerdependency doesn't lint TS files.