Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are some mistakes in test/test.js #76

Closed
finscn opened this issue Dec 12, 2016 · 2 comments
Closed

There are some mistakes in test/test.js #76

finscn opened this issue Dec 12, 2016 · 2 comments

Comments

@finscn
Copy link

finscn commented Dec 12, 2016 •
edited
Loading

I just test one water-huge.json :

The part of it :

2016-12-13 4 35 00

Some triangle are out of polygon.

2016-12-13 4 35 57
@finscn
Copy link
Author

finscn commented Dec 12, 2016

And If the algorithm has been changed (e.g. fix bug #74 ） , the expectedTriangles & expectedDeviation will be changed too.
So the current test case will not valid any more.

@mourner
Copy link
Member

mourner commented Dec 13, 2016

Earcut algorithm does not guarantee fully correct triangulation on self-intersecting geometries. This is stated in the readme.

@mourner mourner closed this as completed Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mourner @finscn