-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-open source fonts #4820
Comments
I think the problem is with the default font, which is also not free. In any case, feel free to remove the non-open-source fonts. |
I think these are quite high level decisions in this project, I just wanted to point out the situation. I'd recommend normalizing everything on Noto Sans, including the specs, but I'm just an outsider making suggestions. |
The Correct me if I'm wrong. |
Even though the font filenames contain the names of non open source fonts, the font files in the demotiles repo are actually open source (see maplibre/demotiles#1). |
Two things are weird for me:
Like I don't yet see how could the fonts repo generate the PBFs in the demotiles repo. The string "arial" is not present in the fonts repo. |
If we really want to keep the Arial name for backwards compatibility, then I recommend
|
Monthly meeting discussion summary: |
I like the idea of the proposed property. Substituting Arial to Noto Sans and deploying this font as "Open Sans Regular, Arial Unicode MS Regular" is still a worthwhile idea though, that way we can clearly point out that the repository only contains open source fonts, even if it contains "Arial" in the name. |
You mean for the demotiles repo? |
I think what's missing is the script to download and process the fonts in the first place. I guess this one needs some tweaking to combine two fonts. |
openmaptiles it outside my reach :-) To generate glyphs there are a few ways as can be seen here: |
I mean the demotiles was generated using that script I believe. Or they were just copied in binaries from OMT, I'm not sure from the repo history. |
I see the best script we have today is from @bdon. Brandon, could you comment about how you made that script? OMT repo has this line "patched by Klokantech", is this what your script is doing? |
It uses https://github.com/maplibre/font-maker from the command line - that script is a bit hacked together, but a closer anaysis of the code points available in each font could lead to more complete coverage. |
Do you think the same strategy could be used to make an Open Sans + Noto Sans font, which could be a true replacement for "Open Sans Regular, Arial Unicode MS Regular"? Does those codepages need to be written manually? I mean, can we not do something which takes all character ranges from Noto and Open and mixes them? |
What is the gain of using Open Sans instead of just Noto for the entire range? We want to exclude CJK since those are big and will be ignored by default with localIdeographs. |
It's just that then we could have an official replacement for the arial named font. The normal range would be identical and the unicode range would be from noto. |
I think this is the best place to organise our efforts. I posted this on bsky as well. Open source MapLibre font stack rabbit holeI'm trying to make one reference PBF font stack for all MapLibre-based maps, including OpenFreeMap. Here's what I've found in the rabbit hole so far: maplibre/demotiles These fonts were generated using openmaptiles/fonts. openmaptiles/fonts repo might have been used to generate the maplibre/demotiles repo. It uses node-fontnik and @mapbox/glyph-pbf-composite. It's not clear what "Noto Sans (patched by Klokan Technologies)" means, and I'm not comfortable with it. A reference font stack should only source official fonts and include a script for any patching if needed. @bdon has a fully open-source script for creating such a patched Noto Sans here: protomaps/basemaps-assets The official release page of Noto Sans is notofonts.github.io - it has a Noto version for approximately 250 languages/writing systems. The Noto Repo has an "experimental build" called megamerge, which combines all the Noto fonts into a single one. Maybe we could simply use NotoSansLiving-Regular.ttf? VersaTiles uses node-fontnik, but there's a bug with the rendering: versatiles-style#29. They're currently considering migrating to PBF Font Tools, developed by Stadia Maps sdf_font_tools/pbf_font_tools, which, if I understand correctly, is an alternative to node-fontnik and maplibre/font-maker. The same repo has sdf_font_tools/build_pbf_glyphs, a CLI builder. I guess we could use Noto Sans megamerge with either font-maker or sdf_font_tools to generate a pure Noto? Also, if someone could help me create the replacement for "Open Sans Regular,Arial Unicode MS Regular" that keeps the Open Sans parts but replaces Arial Unicode with Noto, it would solve the default font issue in MapLibre. |
@hyperknot thanks for the summary, but it is not clear what are the action items that should be done. |
I believe the action is to make a PR to demotiles:
I mean the solution might be like a 10 line script file, nothing serious. I'm just asking for help in deciding what tools to use for these scripts, from those who have experience with these. I mean, at the end, everyone in the ecosystem wants the same fonts for maplibre, so why not unify efforts. |
@HarelM I mean I'm happy to do the PR, I just want to research the topic first. |
Since MapLibre has grown up to be the reference open-source map library, I think it'd be important to remove non-open-source fonts from the codebase, examples and in hosted files.
Please make a grep in the codebase for:
Also, the Arial fonts are actually hosted here, which are probably totally wrong, even if no one noticed it for 3 years:
https://github.com/maplibre/demotiles/tree/gh-pages/font/Open%20Sans%20Regular%2CArial%20Unicode%20MS%20Regular
The text was updated successfully, but these errors were encountered: