Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to allow setting MercatorTransform > pixelsToGLUnits? #4898

Closed
wagewarbler opened this issue Oct 25, 2024 · 1 comment
Closed

Possible to allow setting MercatorTransform > pixelsToGLUnits? #4898

wagewarbler opened this issue Oct 25, 2024 · 1 comment

Comments

@wagewarbler
Copy link
Contributor

#3963 Swaps out Transform for MercatorTransform, and is a huge step in the right direction! 🎆 That said, it changed the shape of the map transform to not allow direct modification of pixesToGLUnits breaking support in downstream libs like react-map-gl for instance. Would it be possible to allow the same sort of assignment in the new API or will this require downstream updates?

@HarelM
Copy link
Collaborator

HarelM commented Oct 26, 2024

5.0 is a breaking change version.
Manipulating the trasform object is not advised for the reason you just mentioned, it's not part of the public API.
My advise would be to define what's needed in terms of public API to support the relevant functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants