Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Initial Doxygen-based documentation for QMapLibre Core #99

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

ntadej
Copy link
Collaborator

@ntadej ntadej commented Jan 7, 2024

Initial Doxygen-based documentation for QMapLibre Core. This for now only covers reference documentation but in interest of keeping PRs manageable, I'm opening the first one already.

As I gave up on qdoc this mainly updates the existing documentation to Doxygen format and ensures everything is consistent.

Eventually we may want to publish this somewhere. To be discussed with @louwers how to do it properly.

@ntadej ntadej requested a review from louwers January 7, 2024 20:41
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (a70dd2a) 45.29% compared to head (3e5aa7b) 45.27%.

Files Patch % Lines
src/core/map.cpp 41.26% 37 Missing ⚠️
src/core/settings.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   45.29%   45.27%   -0.03%     
==========================================
  Files          35       35              
  Lines        2126     2125       -1     
==========================================
- Hits          963      962       -1     
  Misses       1163     1163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntadej
Copy link
Collaborator Author

ntadej commented Jan 14, 2024

Tagging also @cgalvan.

@ntadej ntadej requested review from rinigus and birkskyum January 26, 2024 19:04
@birkskyum
Copy link
Member

birkskyum commented Jan 26, 2024

Doxygen is what maplibre-native uses right?

@ntadej
Copy link
Collaborator Author

ntadej commented Jan 27, 2024

I think so, yes. It is very standard for C++ projects.

@ntadej ntadej merged commit 64a8a97 into maplibre:main Jan 28, 2024
30 of 31 checks passed
@ntadej ntadej deleted the docs branch January 28, 2024 14:21
@ntadej ntadej added this to the 3.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants