Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build instructions should suggest enabling long paths #3136

Open
sargunv opened this issue Jan 10, 2025 · 2 comments
Open

Windows build instructions should suggest enabling long paths #3136

sargunv opened this issue Jan 10, 2025 · 2 comments
Labels
documentation Improvements or additions to documentation windows

Comments

@sargunv
Copy link
Collaborator

sargunv commented Jan 10, 2025

(I'm not very familiar with Windows, so maybe I'm doing something wrong here)

I placed the project near the root of my "dev drive" on Windows, but while recursing submodules, I got a bunch of errors like this:

error: unable to create file output/polygon-with-two-holes-outside-exterior-ring/-3.92212,40.2246,-3.30688,40.4842,simplify_distance=8,strictly_simple=1,fill_type=1,mpu=0,par=0.geojson: Filename too long

It seems Windows has a feature, disabled by default for backwards compatibility with MS-DOS (!), to remove the 256-char restriction on file name lengths. This should probably be documented in the windows build guide here: https://github.com/maplibre/maplibre-native/blob/57f42d92302963e21c37601bc6f0e5bf4a4d48df/platform/windows/README.md

Beyond that change, I also had to git config --system core.longpaths true

@sargunv sargunv added documentation Improvements or additions to documentation windows labels Jan 10, 2025
@louwers
Copy link
Collaborator

louwers commented Jan 10, 2025

I don't know much about Windows either, maybe @tdcosta100 can clarify.

@tdcosta100
Copy link
Collaborator

tdcosta100 commented Jan 13, 2025

Yeah, this is pain in ass, I will change the command in the documentation to include the core.longpaths = true switch, just like we do with the Windows CI. Doing that removes the need to make the setting global, or changing the Windows configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation windows
Projects
None yet
Development

No branches or pull requests

3 participants