Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mapbox Geocoder #13

Open
boldtrn opened this issue Dec 29, 2023 · 0 comments
Open

Remove Mapbox Geocoder #13

boldtrn opened this issue Dec 29, 2023 · 0 comments

Comments

@boldtrn
Copy link
Collaborator

boldtrn commented Dec 29, 2023

Motivation

We would like to remove dependencies on Mapbox.

Implementation

Right now the MapboxGeocoder is only used at one location, in the CarPlayManager. This code part if protected by:
#if canImport(MapboxGeocoder)

One quick fix would be to simply delete the Mapbox dependency from the Cartfile. Everyone using Carplay has to import the Geocoder though.

The better approach would be to remove the Geocoder call from the CarPlayManager and make it easy for implementers to create their own search implementation.

If anyone wants to give this a try, PRs are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant