Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch cleanup #84

Open
wipfli opened this issue Jul 15, 2024 · 7 comments
Open

Branch cleanup #84

wipfli opened this issue Jul 15, 2024 · 7 comments

Comments

@wipfli
Copy link

wipfli commented Jul 15, 2024

Thanks for all the good contributions to this repo! We have seen quite some activity in the last few months which is nice.

Regarding branches, I suggest someone with knowledge of what is what goes through them and deletes all unused branches.

Usually in other repos in the MapLibre org we do the following:

  • normal contributions are made on branches of a fork, for example on the repo wipfli/maplibre-navigation-ios
  • larger contributions that take weeks to months and that are composed of many individual pull requests can be made on branches in the maplibre repo, i.e., maplibre/maplibre-navigation-ios

Would this approach also make sense to the contributors/maintainers of maplibre-navigation-ios?

@hactar
Copy link
Collaborator

hactar commented Jul 15, 2024

I think the "delete branch after merge" setting may be off? I think most of the branches are probably stale after they got merged into main. I suggest turning that feature on to prevent branches from accumulating.

@wipfli
Copy link
Author

wipfli commented Jul 15, 2024

Do you mean this one @hactar ?

image

@hactar
Copy link
Collaborator

hactar commented Jul 15, 2024

Yes. We still need to clean up the existing branches ourselves, but at least this would prevent the growth of unused branches in future.

@wipfli
Copy link
Author

wipfli commented Jul 15, 2024

OK I changed that setting.

@hactar
Copy link
Collaborator

hactar commented Jul 15, 2024

I've browsed through them, cleaned up my own, and deleted a few that were clearly debug branches or commitless. I've also noticed that nearly all stale branches are by @birkskyum - maybe @birkskyum can tell us if there's any hidden gems in the branches we have?

@birkskyum
Copy link
Member

Oh really, I'll go through them later today

@birkskyum
Copy link
Member

birkskyum commented Jul 15, 2024

UPDATE: I honestly don't know why I'm associated to all these branches. None of them appear familiar to me, so maybe it's leftovers from a repository transfer/onboarding. I'm not aware of anything of value in the branches, but I'd prefer to have someone with more experienced in navigation scan through the branches with my name on and make the judgement call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants