MapRoulette Favicon Not Displaying in Browser Tabs

[ljdelight]

Describe the bug
The browser should display the MapRoulette favicon, as illustrated in the screenshot below. In the example, you can see that the tabs for Google and Firefox each have their respective icons visible, but the MapRoulette tab currently does not have its favicon displayed.

Expected behavior
The MapRoulette favicon should be displayed.

To Reproduce
Steps to reproduce the behavior:

1. Open your choice of browser and the dev tools
2. Visit the maproulette.org site
3. See that the favicon is not displayed
4. Look at the 'Network' request and look for 404s for the favicon images

Desktop (please complete the following information):

• OS: Fedora 38
• Browser: Firefox
• Version: 120.0

Additional context
The nginx logs confirm this was not found:

[11/Dec/2023:04:22:11 +0000] "GET /assets/images/favicons/favicon-16x16.png HTTP/1.1" 404 472 "https://staging.maproulette.org/" "Mozilla/5.0 (X11; Linux x86_64; rv:120.0) Gecko/20100101 Firefox/120.0"
[11/Dec/2023:04:22:11 +0000] "GET /assets/images/favicons/apple-touch-icon.png HTTP/1.1" 404 476 "https://staging.maproulette.org/" "Mozilla/5.0 (X11; Linux x86_64; rv:120.0) Gecko/20100101 Firefox/120.0"

[ljdelight]

This is resolved via a small tweak to the deployment scripts (which has its own FE nginx configuration).
The next deployment will pick this up automatically

[ljdelight]

The previous caused a regression by breaking swagger. The /assets path is shared between the API and FE containers, so /assets/lib/ and /assets/swagger.json going to the FE container caused swagger to break.

Resolved with maproulette/maproulette2-docker#95
Swagger is once again working fine on prod 👍