Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Available Meals Section #18

Closed
wants to merge 1 commit into from
Closed

Build: Available Meals Section #18

wants to merge 1 commit into from

Conversation

Saganism
Copy link
Collaborator

No description provided.

This was linked to issues Mar 18, 2021
@maqalaqil maqalaqil self-requested a review March 18, 2021 11:05
Copy link
Owner

@maqalaqil maqalaqil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall amazing work @Saganism .
check the comments i have added and change them

@@ -6,7 +6,9 @@
"@testing-library/jest-dom": "^5.11.4",
"@testing-library/react": "^11.1.0",
"@testing-library/user-event": "^12.1.10",
"bootstrap": "^4.6.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the library for rendering so the test doesn't fail

Learn React
</a>
</header>
<Meals />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed since in future references this will cause merge conflicts

@@ -0,0 +1,7 @@
import * as React from 'react';
import * as renderer from 'react-test-renderer';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test error here

<Carousel>
<CarouselItem>
<div className="items">
<MealCard
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want this to me map array / object so we map it this will help when we reach the back end

@Saganism Saganism closed this Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Available meals slider component Single card meal component
2 participants