Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero component #22

Merged
merged 5 commits into from
Apr 3, 2021
Merged

Hero component #22

merged 5 commits into from
Apr 3, 2021

Conversation

fatimaoday
Copy link
Collaborator

No description provided.

@fatimaoday fatimaoday linked an issue Mar 18, 2021 that may be closed by this pull request
Copy link
Owner

@maqalaqil maqalaqil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good work @fatimaoday please check my comments and fix the changes

.eslintrc.json Outdated Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
src/App.test.js Outdated Show resolved Hide resolved
src/components/CtaButton.jsx Outdated Show resolved Hide resolved
src/components/HeroComponent.css Outdated Show resolved Hide resolved
@fatimaoday
Copy link
Collaborator Author

here is a screenshot of the design when running the code.
Screenshot 2021-03-20 12 47 13

@fatimaoday fatimaoday self-assigned this Mar 20, 2021
Copy link
Owner

@maqalaqil maqalaqil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fatimaoday fatimaoday merged commit 50c311c into dev Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hero component.
2 participants