Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles should preferably be controlled with CSS and not JS #30

Open
ericluwj opened this issue Mar 21, 2016 · 5 comments
Open

Styles should preferably be controlled with CSS and not JS #30

ericluwj opened this issue Mar 21, 2016 · 5 comments

Comments

@ericluwj
Copy link

By relying on JS to set inline styles, I am now finding it very troublesome to implement mobile friendliness. If the styles were controlled with CSS, I could have easily used media queries.

@marcio
Copy link
Owner

marcio commented Mar 21, 2016

@ericluwj thanks for your feedback. I'm thinking an elegant way to use a separated CSS file, instead inline JS styles, maybe an option to escape in line JS styles.

@AdamSkaidon
Copy link

👍 would very much like this over having it in the JS and inline. :)

@viridia
Copy link

viridia commented May 20, 2016

I'd like a way to add an CSS class name to the main dialog element.

@matt16749-zz
Copy link

matt16749-zz commented Jul 12, 2016

👍 any updates?

@jakefavour
Copy link

@viridia : yes being able to pass class names to the components would help a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants