Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fix callbacks for SkylightStateless #74

Open
GuiRitter opened this issue Nov 4, 2018 · 0 comments
Open

Add/fix callbacks for SkylightStateless #74

GuiRitter opened this issue Nov 4, 2018 · 0 comments

Comments

@GuiRitter
Copy link

Hi everyone.

I'm talking about the beforeOpen, afterOpen, beforeClose and afterClose callbacks.

If they also exist for SkylightStateless, they are not working, so they need to be fixed.

If they don't also exist for SkylightStateless, I would suggest that they get implemented for SkylightStateless too.

If they don't exist for SkylightStateless for a reason, I would like for this to be stated clearly somewhere. For example, at marcio.github.io/react-skylight, there is a list of propTypes, but it doesn't list the isVisible prop. This makes me believe that the list of propTypes is for Skylight only. There should be a list for each, or one list explaining in the comments which prop applies to which component.

I've just been in a situation where I needed those callbacks in SkylightStateless. I managed to do what I wanted without them, but it took me a while because either it's not working or it was not supposed to work but I didn't knew about it.

Here's an example of what I'm talking about:
Edit ovo0xj7onq

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant