-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcoded icon fab
option which prevents generic icon usage
#3
Comments
Yes you are absolutely right. I apologize for my mistake. I'm a lone developer and it's very difficult to keep up with everything. |
Absolutely no worries! I'm solo for 99% of what I make. If you wanna copy anything from my fork back into this, feel free ❤️ |
If you want to send a pull request I will accept it immediately. |
I've made quite a few of customizing changes as well 😅 But if you've looked it over and like my changes I'll do that |
My customizations are running on my blog if you want to see what it looks like live: https://queenofsquiggles.github.io/ |
All good, I think it's risky to bring your modifications here. It can break many things that are working. Anyway, thank you very much for the feedback, when I change this repository I will copy what you did. |
In
templates/base.html:189
the hardcoded template configuration prevents customization of icons. For example, I want to add an RSS "branded" icon to my blog footer, but doing so would require finding an associate brand icon as per Bootstrap's Icon Search
For now I'm probably just going to fork with this change (basically requiring branded icons to prefix the "fab fa-" with the icon (which may be less usable for beginners, but is fairly intuitive for me since I can just copy & paste from the search bootstrap provides)
The text was updated successfully, but these errors were encountered: