Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot install on node v11.8.0 #45

Open
huangqibin opened this issue Jan 28, 2019 · 13 comments
Open

cannot install on node v11.8.0 #45

huangqibin opened this issue Jan 28, 2019 · 13 comments

Comments

@huangqibin
Copy link

npm install memwatch-next

[email protected] install /Users/apple/.nvm/node_modules/memwatch-next
node-gyp rebuild

CXX(target) Release/obj.target/memwatch/src/heapdiff.o
../src/heapdiff.cc:95:35: warning: 'ToString' is deprecated: Use maybe version
[-Wdeprecated-declarations]
String::Utf8Value utfString(str->ToString());
^
/Users/apple/.node-gyp/11.8.0/include/node/v8.h:2548:10: note: 'ToString' has
been explicitly marked deprecated here
inline V8_DEPRECATED("Use maybe version", Local ToString() const);
^
/Users/apple/.node-gyp/11.8.0/include/node/v8config.h:326:29: note: expanded
from macro 'V8_DEPRECATED'
declarator attribute((deprecated(message)))
^
../src/heapdiff.cc:95:20: warning: 'Utf8Value' is deprecated: Use Isolate
version [-Wdeprecated-declarations]
String::Utf8Value utfString(str->ToString());
^
/Users/apple/.node-gyp/11.8.0/include/node/v8.h:2991:5: note: 'Utf8Value' has
been explicitly marked deprecated here
V8_DEPRECATED("Use Isolate version",
^
/Users/apple/.node-gyp/11.8.0/include/node/v8config.h:326:29: note: expanded
from macro 'V8_DEPRECATED'
declarator attribute((deprecated(message)))
^
2 warnings generated.
CXX(target) Release/obj.target/memwatch/src/init.o
../src/init.cc:20:9: error: no type named 'AddGCEpilogueCallback' in 'v8::V8';
did you mean 'Nan::GCEpilogueCallback'?
v8::V8::AddGCEpilogueCallback(memwatch::after_gc);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Nan::GCEpilogueCallback
../../nan/nan.h:745:35: note: 'Nan::GCEpilogueCallback' declared here
typedef v8::Isolate::GCCallback GCEpilogueCallback;
^
../src/init.cc:20:49: error: definition or redeclaration of 'after_gc' not
allowed inside a function
v8::V8::AddGCEpilogueCallback(memwatch::after_gc);
~~~~~~~~~~^
2 errors generated.
make: *** [Release/obj.target/memwatch/src/init.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack at ChildProcess.emit (events.js:197:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
gyp ERR! System Darwin 17.7.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/apple/.nvm/node_modules/memwatch-next
gyp ERR! node -v v11.8.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! /Users/apple/.npm/_logs/2019-01-28T06_57_42_231Z-debug.log

@Homer1011110
Copy link

I met this problem on node v10.14.0.

@IslamWahid
Copy link

same here with node v10.15.1

@jsilvia721
Copy link

Also seeing this issue with node v10.10.0

@Zakharen
Copy link

same issue...
anyway, successfully installed on node v8.15.1 (don't forget to remove node_modules before), after I tried different node versions

@kylealwyn
Copy link

Same issue on Node 10.15.0 with same logs. Please let me know if I can provide anything else useful

@Stono
Copy link

Stono commented Apr 23, 2019

I do not see this on:

Versions:
  - Node: v10.15.3
  - NPM:  6.9.0
  - Yarn: 1.15.2
  - Base: 26

@Selhar
Copy link

Selhar commented Apr 30, 2019

Also having this issue on node 11.14.0

@kingces95
Copy link

Hm. Is this tool still being maintained or should we start exploring fixing this ourselves?

@ksteckert
Copy link

ksteckert commented Sep 18, 2019

This issue may be resolved in the fork mentioned in issue #42 (v9+ support). Worth a try.

Here's a link to node-memwatch, a v9+ fork of memwatch-next.

I had a similar error, even with node-memwatch, but with node-memwatch it went away after installing node-gyp rebuild. Hope it helps

npm i node-gyp rebuild
npm i node-memwatch

Also, remember to update your code to require node-memwatch instead of memwatch-next

@100001
Copy link

100001 commented Nov 7, 2019

Also on Node v12.12.0

@RMannOC
Copy link

RMannOC commented Dec 6, 2019

Same issue on Node v12.13.0

The suggestion by @ksteckert did not work

@suhanw
Copy link

suhanw commented Dec 19, 2019

Same issue on Node v12.14.0

@ShanMadane
Copy link

Not working on 13.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests