Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please mark as deprecated #51

Open
JaredCE opened this issue May 7, 2020 · 4 comments
Open

Please mark as deprecated #51

JaredCE opened this issue May 7, 2020 · 4 comments

Comments

@JaredCE
Copy link

JaredCE commented May 7, 2020

Code hasn't been updated since 2017 and doesn't work on latest versions of Node. Please mark this project as deprecated.

@Genysys
Copy link

Genysys commented Jun 17, 2020

Agreed. use this instead: https://github.com/airbnb/node-memwatch

@cool-firer
Copy link

@Genysys looks like there is no leak monitor event

@Venryx
Copy link

Venryx commented Jan 12, 2022

@Genysys looks like there is no leak monitor event

Yes, airbnb's fork removed that part of the code. There explanation was given here.

And here is the code that was removed that was doing the leak detection: https://github.com/airbnb/node-memwatch/pull/1/files#diff-16ab447da591c718a41d43cb70d0f471069f1db23629b3751d8d7af891b20c13L108

It should be possible to re-implement that behavior in userland JS code. If someone does this transformation (it doesn't look too hard), please post the JS code for it here. :)

@Venryx
Copy link

Venryx commented Jan 12, 2022

Hmm, the airbnb fork for me seems to be failing to build on Node v14.17.1 -- at least on Windows.

Have others gotten it to work on Node v14+, on either Linux or Windows?

EDIT: While it failed to install on Windows, that's fine since I don't need the module on my host computer, only in the Docker container (which runs Linux). When installing+running in Linux, the module worked fine, with FROM node:14-alpine as the base image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants