Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package name #38

Open
marcusvolz opened this issue Oct 8, 2021 · 12 comments
Open

Update package name #38

marcusvolz opened this issue Oct 8, 2021 · 12 comments

Comments

@marcusvolz
Copy link
Owner

See initial discussion here: https://twitter.com/mihagazvoda/status/1299996708466761729 @mihagazvoda

I quite like "sportvis"

@datawookie
Copy link
Collaborator

Unless we are planning on supporting other formats (beyond GPX), I'd suggest going with a simple gpx.

@hugovk
Copy link
Contributor

hugovk commented Oct 10, 2021

A somewhat similar thing supports GPX/TCX/FIT/IGC/SKIZ:

https://github.com/erik/derive

@marcusvolz
Copy link
Owner Author

I'm quite keen to support other formats similar to the project that @hugovk mentioned above. My strava bulk export contains a bunch of .fit files and it's a bit of a pain to convert them to gpx. I think the main idea of this package is to create nice plots, so it would be good if the name reflected that somehow.

@datawookie
Copy link
Collaborator

I think the main idea of this package is to create nice plots, so it would be good if the name reflected that somehow.

Well, we could think of this a little differently. It could be a package that handles these various formats and allows the data to be processed in R in a consistent, tidy format (regardless of what format the data came from).

And since the view of the data once in the package is the same the plots should then work across all the data types.

@marcusvolz
Copy link
Owner Author

Agree, it could be both! A package that makes it easy for users to: (1) consolidate their activity data from a variety of sources / formats into a tidy data frame, and (2) create nice plots from that data. From a personal standpoint I am particularly interested in (2) - coming up with and developing new plot designs, so if there are collaborators who are more interested in contributing to (1) that would be amazing.

@datawookie
Copy link
Collaborator

From a personal standpoint I am particularly interested in (2)

Ah, I've seen your Twitter feed: you are a maestro of visualisation.

@BalintKomjati
Copy link
Contributor

Hi All! Following the vision of " (2) create nice plots from that data" I thought a 3D rayshader plot with gpx logs would be a great addition for this package. See e.g. https://www.rayshader.com/reference/figures/README_paths-1.png.
I know rayshader is a standalone package that is a bit out of range here but still it would be nice to be able to generate 3D plots (or at least 1 specific plot) with rstrava out of the box.
Thoughts?

@mihagazvoda
Copy link
Contributor

mihagazvoda commented Oct 19, 2021 via email

@marcusvolz
Copy link
Owner Author

Hi @BalintKomjati I would love to be able to create 3D rayshader plots. Actually I just mentioned this a few days ago in #37

I'd also be keen to see if it's possible to create single-activity 3D maps in R similar to those produced by VeloViewer, e.g. https://twitter.com/VeloViewer/status/1441310475296198663
It looks like rayshader - https://www.rayshader.com/ - might be ideal for this.

@BalintKomjati
Copy link
Contributor

BalintKomjati commented Nov 2, 2021

Hi All!

I am about to put together a rayshader+strava 3D prototype, and just wanted to make sure that nobody is working on the same enhancement? @ColinFay ?


I just realised that there are 2 very similar R packages: 'rStrava' and 'strava'. It seems that rStrava is more about utilizing Strava's API and pulling data while 'strava' is about visualization.

Is there any cooperation or functionality distribution agreement between the 2 teams?

Is there a reason this package suggest to bulk download activity data from the strava website manually and not via its API using 'rStrava'? The latter looks like a reasonable add-on to me.
@marcusvolz ?

@marcusvolz
Copy link
Owner Author

Hi @BalintKomjati,

1 - Thanks for offering to put together a rayshader 3d prototype! I personally have not done any 3d visualizations at this stage and am not aware of anyone else working on this.

2 - There was some early discussion about integrating the two packages, but it did not eventuate (I am still open to this though if there is interest). One advantage of using bulk export files is that the plots can be generated from other data sources besides Strava (e.g. RunKeeper).

@BalintKomjati
Copy link
Contributor

BalintKomjati commented Nov 5, 2021

Hi @marcusvolz

  1. cool, i will open a separate issue and will try to come back with a PR in the coming weeks!
  2. ok, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants