Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--reveal-js-opts ignored except theme #40

Open
faassen opened this issue Nov 21, 2013 · 2 comments
Open

--reveal-js-opts ignored except theme #40

faassen opened this issue Nov 21, 2013 · 2 comments

Comments

@faassen
Copy link
Contributor

faassen commented Nov 21, 2013

The documentation says --reveal-js-opts are passed to the post processor, in this case the reveal.js post processor. I expected that this could be used to pass options into the Reveal.initialize() function. Except for theme they are however ignored; I can't find code that would generate this either - it always creates a fixed initialize().

Perhaps I don't understand the documentation correctly?

@marianoguerra
Copy link
Owner

the opts are not passed to initialize, but to the postprocessor in python, which only understands theme:

https://github.com/marianoguerra/rst2html5/blob/master/html5css3/postprocessors.py#L116

what other option you want to pass in? maybe I can pass the whole params to initialize as json, but that may cause a problem, what do you think?

@faassen
Copy link
Contributor Author

faassen commented Nov 21, 2013

From reading the docs I get the impression that the opts would be passed to reveal.js (as theme seems to be, though it's a different mechanism).

Dumping the remaining params as json is just what I did in my pull request. I myself wanted to turn off the controls, but there are a lot of other possibilities, such as setting the presentation size. See here:

https://github.com/hakimel/reveal.js/#configuration

and here:

https://github.com/hakimel/reveal.js/#presentation-size

(among other options)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants